spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xysun <...@git.apache.org>
Subject [GitHub] spark pull request #20649: [SPARK-23462][SQL] improve missing field error me...
Date Mon, 05 Mar 2018 03:30:08 GMT
Github user xysun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20649#discussion_r172084508
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ---
    @@ -284,7 +286,8 @@ case class StructType(fields: Array[StructField]) extends DataType
with Seq[Stru
         val nonExistFields = names -- fieldNamesSet
         if (nonExistFields.nonEmpty) {
           throw new IllegalArgumentException(
    -        s"Field ${nonExistFields.mkString(",")} does not exist.")
    +        s"""Fields ${nonExistFields.mkString(", ")} does not exist.
    --- End diff --
    
    "Field(s) ... do(es) not exist." like this? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message