spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sethah <...@git.apache.org>
Subject [GitHub] spark pull request #20632: [SPARK-3159][ML] Add decision tree pruning
Date Fri, 02 Mar 2018 22:45:01 GMT
Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20632#discussion_r171982559
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
    @@ -703,4 +707,16 @@ private object RandomForestSuite {
         val (indices, values) = map.toSeq.sortBy(_._1).unzip
         Vectors.sparse(size, indices.toArray, values.toArray)
       }
    +
    +  @tailrec
    +  private def getSumLeafCounters(nodes: List[Node], acc: Long = 0): Long =
    --- End diff --
    
    Need to enclose the function body in curly braces


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message