spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdblue <...@git.apache.org>
Subject [GitHub] spark pull request #20692: [SPARK-23531][SQL] Show attribute type in explain
Date Thu, 01 Mar 2018 16:59:40 GMT
Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20692#discussion_r171624644
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
    @@ -106,7 +106,7 @@ abstract class Attribute extends LeafExpression with NamedExpression
with NullIn
     
       override def toAttribute: Attribute = this
       def newInstance(): Attribute
    -
    +  def stringWithType: String = s"$toString: ${dataType.simpleString}"
    --- End diff --
    
    Nit: the `:` isn't needed and will accumulate to quite a few extra characters in plans.
SQL uses `(id bigint, data string)` without `:` so I think we should mirror that.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message