spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...
Date Thu, 01 Mar 2018 14:53:20 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19222#discussion_r171582505
  
    --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -50,12 +52,10 @@
     
       // These are only updated by readExternal() or read()
       @Nonnull
    -  private Object base;
    -  private long offset;
    -  private int numBytes;
    +  private MemoryBlock base;
     
    -  public Object getBaseObject() { return base; }
    -  public long getBaseOffset() { return offset; }
    +  public MemoryBlock getBaseObject() { return base; }
    --- End diff --
    
    This changes the semantics, shall we return `base.getBaseObject`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message