From reviews-return-619934-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Feb 28 10:20:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 010E4180657 for ; Wed, 28 Feb 2018 10:20:03 +0100 (CET) Received: (qmail 730 invoked by uid 500); 28 Feb 2018 09:20:03 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 529 invoked by uid 99); 28 Feb 2018 09:20:02 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Feb 2018 09:20:02 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5C20FE980E; Wed, 28 Feb 2018 09:20:02 +0000 (UTC) From: xysun To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #20649: [SPARK-23462][SQL] improve missing field error me... Content-Type: text/plain Message-Id: <20180228092002.5C20FE980E@git1-us-west.apache.org> Date: Wed, 28 Feb 2018 09:20:02 +0000 (UTC) Github user xysun commented on a diff in the pull request: https://github.com/apache/spark/pull/20649#discussion_r171182128 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StructTypeSuite.scala --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +import org.apache.spark.SparkFunSuite +import org.apache.spark.sql.types.StructType + +class StructTypeSuite extends SparkFunSuite { + + test("SPARK-23462 lookup a single missing field should output existing fields") { --- End diff -- removed JIRA number. @kiszk i still prefer to keep separate tests as they are calling separate methods. Let me know if you feel strongly against it. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org