From reviews-return-614239-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Feb 8 19:44:11 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 6D72118064F for ; Thu, 8 Feb 2018 19:44:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5D662160C34; Thu, 8 Feb 2018 18:44:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9AF1E160C4A for ; Thu, 8 Feb 2018 19:44:10 +0100 (CET) Received: (qmail 59082 invoked by uid 500); 8 Feb 2018 18:44:09 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 59029 invoked by uid 99); 8 Feb 2018 18:44:09 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Feb 2018 18:44:09 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7928DDFBC6; Thu, 8 Feb 2018 18:44:08 +0000 (UTC) From: BryanCutler To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #20531: [SPARK-23352][PYTHON] Explicitly specify supporte... Content-Type: text/plain Message-Id: <20180208184408.7928DDFBC6@git1-us-west.apache.org> Date: Thu, 8 Feb 2018 18:44:08 +0000 (UTC) Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20531#discussion_r167029101 --- Diff: docs/sql-programming-guide.md --- @@ -1734,7 +1734,7 @@ For detailed usage, please see [`pyspark.sql.functions.pandas_udf`](api/python/p ### Supported SQL Types -Currently, all Spark SQL data types are supported by Arrow-based conversion except `MapType`, +Currently, all Spark SQL data types are supported by Arrow-based conversion except `BinaryType`, `MapType`, --- End diff -- should `BinaryType` be added to the unsupported types with arrow.enabled in SQLConf.scala? --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org