From reviews-return-613169-archive-asf-public=cust-asf.ponee.io@spark.apache.org Tue Feb 6 20:09:18 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 6FDC3180677 for ; Tue, 6 Feb 2018 20:09:18 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5FC33160C45; Tue, 6 Feb 2018 19:09:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8E2B4160C46 for ; Tue, 6 Feb 2018 20:09:17 +0100 (CET) Received: (qmail 12977 invoked by uid 500); 6 Feb 2018 19:09:16 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 12845 invoked by uid 99); 6 Feb 2018 19:09:15 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Feb 2018 19:09:15 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 63F6FE8F23; Tue, 6 Feb 2018 19:09:15 +0000 (UTC) From: vanzin To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #20474: [SPARK-23235][Core] Add executor Threaddump to ap... Content-Type: text/plain Message-Id: <20180206190915.63F6FE8F23@git1-us-west.apache.org> Date: Tue, 6 Feb 2018 19:09:15 +0000 (UTC) Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20474#discussion_r166409000 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala --- @@ -51,6 +51,31 @@ private[v1] class AbstractApplicationResource extends BaseAppResource { @Path("executors") def executorList(): Seq[ExecutorSummary] = withUI(_.store.executorList(true)) + @GET + @Path("executors/{executorId}/threads") + def threadDump(@PathParam("executorId") executorId: String): Response = withUI { ui => + def isAllDigits(x: String) = x.forall(Character.isDigit) --- End diff -- You only call this in one place, so I'd just inline it. The code is just as self-explanatory as the method name. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org