spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From drboyer <...@git.apache.org>
Subject [GitHub] spark pull request #20658: [SPARK-23488][python] Add missing catalog methods...
Date Thu, 22 Feb 2018 05:28:49 GMT
GitHub user drboyer opened a pull request:

    https://github.com/apache/spark/pull/20658

    [SPARK-23488][python] Add missing catalog methods to python API

    ## What changes were proposed in this pull request?
    
    As noted in SPARK-23488, the Python Catalog API was missing some methods that are present
in the Scala API. Both for the sake of consistency, and because of their utility, I've added
the missing methods (the database/table/functionExists() and getDatabase/Table/Function()
methods).
    
    I modeled these methods off of how the existing ones were written in catalog.py.
    
    ## How was this patch tested?
    
    manually tested the added methods and compared functionality to the scala API counterparts
    
    ## Questions
    
    I wasn't sure whether to set the `@since(x.y)` decorators on the new functions, and if
so, what value to set them to?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/drboyer/spark add-other-catalog-methods

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20658.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20658
    
----
commit c82394a87d1a36b3fc899553433119d5ca8bc28f
Author: Devin Boyer <drb5272@...>
Date:   2018-02-22T05:06:37Z

    add missing catalog methods to python API

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message