spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From krcz <...@git.apache.org>
Subject [GitHub] spark pull request #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler ...
Date Tue, 20 Feb 2018 15:17:18 GMT
GitHub user krcz opened a pull request:

    https://github.com/apache/spark/pull/20641

    [SPARK-23464][MESOS] Fix mesos cluster scheduler options double-escaping

    ## What changes were proposed in this pull request?
    
    Don't enclose --conf option value with "", as they are already escaped by shellEscape
    and additional wrapping cancels out this escaping, making the driver fail to start.
    
    This reverts commit 9b377aa49f14af31f54164378d60e0fdea2142e5 [SPARK-18114].
    
    ## How was this patch tested?
    
    Manual test with driver command logging added.
    
    Author: Marcin Kurczych <marcin.kurczych@iqvia.com>
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/krcz/spark mesos-double-escaping

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20641.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20641
    
----
commit e4c5fb12d732029727ba6772732734c511c1f6fa
Author: Marcin Kurczych <marcin.kurczych@...>
Date:   2018-02-20T15:12:09Z

    [SPARK-23464][MESOS] Fix mesos cluster scheduler options double-escaping
    
    Don't enclose --conf option value with "", as they are already escaped by shellEscape
    and additional wrapping cancels out this escaping, causing driver fail to start.
    
    This reverts commit 9b377aa49f14af31f54164378d60e0fdea2142e5 [SPARK-18114].
    
    Manual test with driver command logging added.
    
    Author: Marcin Kurczych <marcin.kurczych@iqvia.com>

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message