spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xysun <...@git.apache.org>
Subject [GitHub] spark pull request #20649: [SPARK-23462][SQL] improve missing field error me...
Date Wed, 28 Feb 2018 09:20:02 GMT
Github user xysun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20649#discussion_r171182128
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StructTypeSuite.scala ---
    @@ -0,0 +1,43 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql
    +
    +import org.apache.spark.SparkFunSuite
    +import org.apache.spark.sql.types.StructType
    +
    +class StructTypeSuite extends SparkFunSuite {
    +
    +  test("SPARK-23462 lookup a single missing field should output existing fields") {
    --- End diff --
    
    removed JIRA number.
    @kiszk i still prefer to keep separate tests as they are calling separate methods. Let
me know if you feel strongly against it. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message