spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuanyuanking <...@git.apache.org>
Subject [GitHub] spark pull request #20675: [SPARK-23033][SS][Follow Up] Task level retry for...
Date Wed, 28 Feb 2018 07:33:09 GMT
Github user xuanyuanking commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20675#discussion_r171161352
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/ContinuousDataReader.java
---
    @@ -33,4 +33,16 @@
          * as a restart checkpoint.
          */
         PartitionOffset getOffset();
    +
    +    /**
    +     * Set the start offset for the current record, only used in task retry. If setOffset
keep
    +     * default implementation, it means current ContinuousDataReader can't support task
level retry.
    +     *
    +     * @param offset last offset before task retry.
    +     */
    +    default void setOffset(PartitionOffset offset) {
    --- End diff --
    
    Cool, that's more clearer.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message