spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sethah <...@git.apache.org>
Subject [GitHub] spark pull request #20632: [SPARK-3159] added subtree pruning in the transla...
Date Tue, 27 Feb 2018 21:35:59 GMT
Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20632#discussion_r171071028
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
    @@ -92,6 +92,7 @@ private[spark] object RandomForest extends Logging {
           featureSubsetStrategy: String,
           seed: Long,
           instr: Option[Instrumentation[_]],
    +      prune: Boolean = true,
    --- End diff --
    
    how about a comment here: `prune: Boolean = true, // exposed for testing only, real trees
are always pruned`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message