spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...
Date Sat, 17 Feb 2018 17:29:57 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20057#discussion_r168927608
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala ---
    @@ -42,4 +42,17 @@ private object MsSqlServerDialect extends JdbcDialect {
       }
     
       override def isCascadingTruncateTable(): Option[Boolean] = Some(false)
    +
    +  /**
    +   * The SQL query used to truncate a table.
    +   * @param table The JDBCOptions.
    +   * @param cascade Whether or not to cascade the truncation. Default value is the
    +   *                value of isCascadingTruncateTable(). Ignored for MsSql as it is unsupported.
    --- End diff --
    
    I think we can ignore `Ignored for MsSql as it is unsupported.` here.
    If you want, you can make a function comment of `override def isCascadingTruncateTable():
Option[Boolean] = Some(false)`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message