spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #20610: [SPARK-23426][SQL] Use `hive` ORC impl and disabl...
Date Wed, 14 Feb 2018 23:48:46 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20610#discussion_r168347455
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
---
    @@ -207,6 +207,16 @@ class FileStreamSourceSuite extends FileStreamSourceTest {
           .collect { case s @ StreamingRelation(dataSource, _, _) => s.schema }.head
       }
     
    +  override def beforeAll(): Unit = {
    +    super.beforeAll()
    +    spark.sessionState.conf.setConf(SQLConf.ORC_IMPLEMENTATION, "native")
    +  }
    +
    +  override def afterAll(): Unit = {
    +    spark.sessionState.conf.unsetConf(SQLConf.ORC_IMPLEMENTATION)
    +    super.afterAll()
    --- End diff --
    
    ```
        try {
          spark.sessionState.conf.unsetConf(SQLConf.ORC_IMPLEMENTATION)
        } finally {
          super.afterAll()
        }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message