spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #20546: [SPARK-20659][Core] Removing sc.getExecutorStorag...
Date Wed, 14 Feb 2018 11:12:11 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20546#discussion_r168143242
  
    --- Diff: core/src/main/java/org/apache/spark/SparkExecutorInfo.java ---
    @@ -30,4 +30,8 @@
       int port();
       long cacheSize();
       int numRunningTasks();
    +  long usedOnHeapStorageMemory();
    --- End diff --
    
    1. That follows the names in the public `MemoryMetrics` class from the REST API.
    2. We could add that, just as we could add a whole lot of other things. At some point
we should look at exposing the REST API types directly through `SparkStatusTracker` instead
of having these mirror types.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message