spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source...
Date Tue, 13 Feb 2018 10:20:16 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20554#discussion_r167809278
  
    --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala
---
    @@ -303,94 +302,75 @@ class KafkaMicroBatchSourceSuite extends KafkaSourceSuiteBase {
         )
       }
     
    -  testWithUninterruptibleThread(
    --- End diff --
    
    Agreed. How about just writing a test to make sure we do write 0 at the beginning?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message