spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #20571: [SPARK-23383][Build][Minor]Make a distribution sh...
Date Sun, 11 Feb 2018 14:46:33 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20571#discussion_r167437130
  
    --- Diff: dev/make-distribution.sh ---
    @@ -72,8 +76,15 @@ while (( "$#" )); do
         --help)
           exit_with_usage
           ;;
    +    --*)
    --- End diff --
    
    I think this is fine. It will print usage for every unrecognized arg, but, that's probably
OK, as it's rare to have more than one.
    
    I guess the other option is to fail outright to make sure the user knows the command wasn't
parsed as given. How about that? I don't feel strongly.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message