spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #20516: [SPARK-23343][CORE][TEST] Increase the exception ...
Date Sat, 10 Feb 2018 16:45:31 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20516#discussion_r167403542
  
    --- Diff: project/SparkBuild.scala ---
    @@ -792,7 +792,6 @@ object TestSettings {
           "JAVA_HOME" -> sys.env.get("JAVA_HOME").getOrElse(sys.props("java.home"))),
         javaOptions in Test += s"-Djava.io.tmpdir=$testTempDir",
         javaOptions in Test += "-Dspark.test.home=" + sparkHome,
    -    javaOptions in Test += "-Dspark.testing=1",
    --- End diff --
    
    This is still set in the Maven build though. While you could also remove it there, maybe
simplest to leave this as-is. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message