spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdblue <...@git.apache.org>
Subject [GitHub] spark pull request #20490: [SPARK-23323][SQL]: Support commit coordinator fo...
Date Fri, 09 Feb 2018 16:40:27 GMT
Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20490#discussion_r167280511
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
    @@ -62,6 +62,16 @@
        */
       DataWriterFactory<Row> createWriterFactory();
     
    +  /**
    +   * Returns whether Spark should use the commit coordinator to ensure that only one
attempt for
    --- End diff --
    
    Currently, the commit coordinator will only authorize one attempt and only authorize another
if the authorized attempt fails, so it does ensure that only one attempt commits. Do you think
the wording here needs to change?
    
    Instead of documenting the behavior of the commit coordinator here, I'd rather point to
its docs. Are those written, or is the coordinator an internal class?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message