spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ueshin <...@git.apache.org>
Subject [GitHub] spark pull request #20531: [SPARK-23352][PYTHON] Explicitly specify supporte...
Date Thu, 08 Feb 2018 05:12:13 GMT
Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20531#discussion_r166832153
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -4562,14 +4585,14 @@ def test_basic(self):
             self.assertPandasEqual(expected4.toPandas(), result4.toPandas())
     
         def test_unsupported_types(self):
    -        from pyspark.sql.types import ArrayType, DoubleType, MapType
    +        from pyspark.sql.types import DoubleType, MapType
             from pyspark.sql.functions import pandas_udf, PandasUDFType
     
             with QuietTest(self.sc):
                 with self.assertRaisesRegexp(NotImplementedError, 'not supported'):
    -                @pandas_udf(ArrayType(DoubleType()), PandasUDFType.GROUPED_AGG)
    +                @pandas_udf(ArrayType(ArrayType(TimestampType())), PandasUDFType.GROUPED_AGG)
                     def mean_and_std_udf(v):
    --- End diff --
    
    nit: should rename this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message