spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #20474: [SPARK-23235][Core] Add executor Threaddump to ap...
Date Tue, 06 Feb 2018 19:09:15 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20474#discussion_r166409000
  
    --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala
---
    @@ -51,6 +51,31 @@ private[v1] class AbstractApplicationResource extends BaseAppResource
{
       @Path("executors")
       def executorList(): Seq[ExecutorSummary] = withUI(_.store.executorList(true))
     
    +  @GET
    +  @Path("executors/{executorId}/threads")
    +  def threadDump(@PathParam("executorId") executorId: String): Response = withUI { ui
=>
    +    def isAllDigits(x: String) = x.forall(Character.isDigit)
    --- End diff --
    
    You only call this in one place, so I'd just inline it. The code is just as self-explanatory
as the method name.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message