spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...
Date Tue, 06 Feb 2018 12:21:44 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20499#discussion_r166278935
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -1532,7 +1532,7 @@ def fillna(self, value, subset=None):
                 return DataFrame(self._jdf.na().fill(value, self._jseq(subset)), self.sql_ctx)
     
         @since(1.4)
    -    def replace(self, to_replace, value=None, subset=None):
    +    def replace(self, to_replace, *args, **kwargs):
    --- End diff --
    
    what's the expectation? if `to_replace` is a dict, `value` should be ignored?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message