spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #20462: [SPARK-23020][core] Fix another race in the in-pr...
Date Thu, 01 Feb 2018 02:53:22 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20462#discussion_r165248266
  
    --- Diff: launcher/src/main/java/org/apache/spark/launcher/InProcessAppHandle.java ---
    @@ -66,7 +66,7 @@ synchronized void start(String appName, Method main, String[] args)
{
             setState(State.FAILED);
           }
     
    -      disconnect();
    +      dispose();
    --- End diff --
    
    If we call `disconnect` here, we would close the connection, and then wait the close to
finish in `dispose`. If we call `dispose` directly, we also close and wait the connection(in
`waitForClose`). What the actual difference here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message