From reviews-return-601631-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Jan 11 17:49:00 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id C1C1A180656 for ; Thu, 11 Jan 2018 17:49:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B1054160C20; Thu, 11 Jan 2018 16:49:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EF5A8160C1F for ; Thu, 11 Jan 2018 17:48:59 +0100 (CET) Received: (qmail 28202 invoked by uid 500); 11 Jan 2018 16:48:59 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 28191 invoked by uid 99); 11 Jan 2018 16:48:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jan 2018 16:48:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B9144EE68A; Thu, 11 Jan 2018 16:48:55 +0000 (UTC) From: smurakozi To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #20203: [SPARK-22577] [core] executor page blacklist stat... Content-Type: text/plain Message-Id: <20180111164856.B9144EE68A@git1-us-west.apache.org> Date: Thu, 11 Jan 2018 16:48:55 +0000 (UTC) Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/20203#discussion_r161001141 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -211,6 +211,11 @@ private[spark] class AppStatusListener( updateBlackListStatus(event.executorId, true) } + override def onExecutorBlacklistedForStage( + event: SparkListenerExecutorBlacklistedForStage): Unit = { + updateBlackListStatusForStage(event.executorId, event.stageId, event.stageAttemptId) + } + --- End diff -- Consider covering this functionality (updating the status) in AppStatusListenerSuite. We already have a check for blacklisting an executor, we should have the same for a stage. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org