spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #20416: [SPARK-23248][PYTHON][EXAMPLES] Relocate module d...
Date Sat, 27 Jan 2018 12:19:33 GMT
GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/20416

    [SPARK-23248][PYTHON][EXAMPLES] Relocate module docstrings to the top in PySpark examples

    ## What changes were proposed in this pull request?
    
    This PR proposes to relocate the docstrings in modules of examples to the top. Seems these
are mistakes. So, for example, the below codes
    
    ```python
    >>> help(aft_survival_regression)
    ```
    
    shows the module docstrings for examples as below:
    
    **Before**
    
    ```
    Help on module aft_survival_regression:
    
    NAME
        aft_survival_regression
    
    ...
    
    DESCRIPTION
        # Licensed to the Apache Software Foundation (ASF) under one or more
        # contributor license agreements.  See the NOTICE file distributed with
        # this work for additional information regarding copyright ownership.
        # The ASF licenses this file to You under the Apache License, Version 2.0
        # (the "License"); you may not use this file except in compliance with
        # the License.  You may obtain a copy of the License at
        #
        #    http://www.apache.org/licenses/LICENSE-2.0
        #
        # Unless required by applicable law or agreed to in writing, software
        # distributed under the License is distributed on an "AS IS" BASIS,
        # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        # See the License for the specific language governing permissions and
        # limitations under the License.
        #
    
    ...
    
    (END)
    ```
    
    **After**
    
    ```
    Help on module aft_survival_regression:
    
    NAME
        aft_survival_regression
    
    ...
    
    DESCRIPTION
        An example demonstrating aft survival regression.
        Run with:
          bin/spark-submit examples/src/main/python/ml/aft_survival_regression.py
    
    (END)
    ```
    
    ## How was this patch tested?
    
    Manually checked.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark module-docstring-example

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20416
    
----
commit f2026ebb3b0a0bf00f0f9229fceae1e70b3b6398
Author: hyukjinkwon <gurwls223@...>
Date:   2018-01-27T12:05:26Z

    Relocate module docstrings to the top in PySpark examples

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message