spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types...
Date Fri, 12 Jan 2018 05:01:57 GMT
GitHub user maropu opened a pull request:

    https://github.com/apache/spark/pull/20245

    [SPARK-21213][SQL][FOLLOWUP] Use compatible types for comparisons in compareAndGetNewStats

    ## What changes were proposed in this pull request?
    This pr fixed code to compare values in `compareAndGetNewStats`.
    The test below fails in the current master;
    ```
        val oldStats2 = CatalogStatistics(sizeInBytes = BigInt(Long.MaxValue) * 2)
        val newStats5 = CommandUtils.compareAndGetNewStats(
          Some(oldStats2), newTotalSize = BigInt(Long.MaxValue) * 2, None)
        assert(newStats5.isEmpty)
    ```
    
    ## How was this patch tested?
    Added some tests in `CommandUtilsSuite`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maropu/spark SPARK-21213-FOLLOWUP

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20245
    
----
commit 473b37a1d2abd74f66d29883a1e8bb488cf6bb94
Author: Takeshi Yamamuro <yamamuro@...>
Date:   2018-01-12T04:57:32Z

    Use compatible types for comparisons in compareAndGetNewStats

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message