spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #20189: [SPARK-22975] MetricsReporter should not throw ex...
Date Mon, 08 Jan 2018 22:39:29 GMT
GitHub user mgaido91 opened a pull request:

    https://github.com/apache/spark/pull/20189

    [SPARK-22975] MetricsReporter should not throw exception when there was no progress reported

    ## What changes were proposed in this pull request?
    
    `MetricsReporter ` assumes that there has been some progress for the query, ie. `lastProgress`
is not null. If this is not true, as it might happen in particular conditions, a `NullPointerException`
can be thrown.
    
    The PR checks whether there is a `lastProgress` and if this is not true, it returns a
default value for the metrics.
    
    ## How was this patch tested?
    
    added UT


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/spark SPARK-22975

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20189.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20189
    
----
commit 1185a513bd807df03a24b22370903d17301fd415
Author: Marco Gaido <marcogaido91@...>
Date:   2018-01-08T22:28:12Z

    [SPARK-22975] MetricsReporter should not throw exception when there was no progress reported

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message