spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jose-torres <...@git.apache.org>
Subject [GitHub] spark pull request #20386: [SPARK-23202][SQL] Break down DataSourceV2Writer....
Date Tue, 30 Jan 2018 16:47:41 GMT
Github user jose-torres commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20386#discussion_r164805751
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ConsoleWriterSuite.scala
---
    @@ -34,9 +33,9 @@ class ConsoleWriterSuite extends StreamTest {
         Console.withOut(captured) {
           val query = input.toDF().writeStream.format("console").start()
           try {
    -        input.addData(1, 2, 3)
    +        input.addData(1, 1, 1)
    --- End diff --
    
    Makes sense, but can we set the parallelism to 1 instead? I worry that making all the
elements the same is more likely to disguise a bug.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message