spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #20405: [SPARK-23229][SQL] Dataset.hint should use planWi...
Date Sat, 27 Jan 2018 08:26:35 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20405#discussion_r164267184
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -1216,7 +1216,7 @@ class Dataset[T] private[sql](
        */
       @scala.annotation.varargs
       def hint(name: String, parameters: Any*): Dataset[T] = withTypedPlan {
    -    UnresolvedHint(name, parameters, logicalPlan)
    +    UnresolvedHint(name, parameters, planWithBarrier)
    --- End diff --
    
    @jaceklaskowski Because the logical plan is wrapped in analysis barrier, `ResolveBroadcastHints`
can't traverse down it to reach the `UnresolvedRelation` at https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala#L60-L61.
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message