spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From foxish <...@git.apache.org>
Subject [GitHub] spark pull request #20383: [SPARK-23200] Reset Kubernetes-specific config on...
Date Fri, 26 Jan 2018 11:01:34 GMT
Github user foxish commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20383#discussion_r164084503
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala ---
    @@ -53,6 +53,21 @@ class Checkpoint(ssc: StreamingContext, val checkpointTime: Time)
           "spark.driver.host",
           "spark.driver.bindAddress",
           "spark.driver.port",
    +      "spark.kubernetes.driver.pod.name",
    +      "spark.kubernetes.executor.podNamePrefix",
    +      "spark.kubernetes.initcontainer.executor.configmapname",
    +      "spark.kubernetes.initcontainer.executor.configmapkey",
    +      "spark.kubernetes.initcontainer.downloadJarsResourceIdentifier",
    +      "spark.kubernetes.initcontainer.downloadJarsSecretLocation",
    +      "spark.kubernetes.initcontainer.downloadFilesResourceIdentifier",
    +      "spark.kubernetes.initcontainer.downloadFilesSecretLocation",
    +      "spark.kubernetes.initcontainer.remoteJars",
    +      "spark.kubernetes.initcontainer.remoteFiles",
    +      "spark.kubernetes.mountdependencies.jarsDownloadDir",
    +      "spark.kubernetes.mountdependencies.filesDownloadDir",
    +      "spark.kubernetes.initcontainer.executor.stagingServerSecret.name",
    --- End diff --
    
    Sorry - should have caught this. The `stagingServer` configs don't exist in upstream.
We should remove those, although it's a NOP here I'm guessing. 
    
    @ssaavedra @felixcheung 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message