spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjffdu <...@git.apache.org>
Subject [GitHub] spark pull request #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pys...
Date Fri, 26 Jan 2018 09:47:46 GMT
Github user zjffdu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13599#discussion_r164069473
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/PythonRunner.scala ---
    @@ -39,12 +39,17 @@ object PythonRunner {
         val pyFiles = args(1)
         val otherArgs = args.slice(2, args.length)
         val sparkConf = new SparkConf()
    -    val pythonExec = sparkConf.get(PYSPARK_DRIVER_PYTHON)
    +    var pythonExec = sparkConf.get(PYSPARK_DRIVER_PYTHON)
    --- End diff --
    
    I  am afraid I have to use var, because `VirtualenvFactory` also need `pythonExec` as
constructor arg.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message