spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #20224: [SPARK-23032][SQL] Add a per-query codegenStageId...
Date Thu, 25 Jan 2018 07:34:46 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20224#discussion_r163767104
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -629,6 +629,13 @@ object SQLConf {
         .booleanConf
         .createWithDefault(true)
     
    +  val WHOLESTAGE_CODEGEN_USE_ID_IN_CLASS_NAME =
    +    buildConf("spark.sql.codegen.wholeStage.useIdInClassName")
    --- End diff --
    
    Logically it's better to have the `wholeStage` prefix, let's start from here that always
adding `wholeStage` prefix to whole stage related config.(keep the existing one unchanged)
    
    cc @viirya 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message