spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From henryr <...@git.apache.org>
Subject [GitHub] spark pull request #20355: SPARK-23148: [SQL] Allow pathnames with special c...
Date Wed, 24 Jan 2018 00:26:05 GMT
Github user henryr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20355#discussion_r163422934
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
---
    @@ -68,13 +68,16 @@ class FileBasedDataSourceSuite extends QueryTest with SharedSQLContext
{
       }
     
       allFileBasedDataSources.foreach { format =>
    -    test(s"SPARK-22146 read files containing special characters using $format") {
    -      val nameWithSpecialChars = s"sp&cial%chars"
    -      withTempDir { dir =>
    -        val tmpFile = s"$dir/$nameWithSpecialChars"
    -        spark.createDataset(Seq("a", "b")).write.format(format).save(tmpFile)
    -        val fileContent = spark.read.format(format).load(tmpFile)
    -        checkAnswer(fileContent, Seq(Row("a"), Row("b")))
    +    test(s"SPARK-22146 / SPARK-23148 read files containing special characters using $format")
{
    +      val nameWithSpecialChars = s"sp&cial%c hars"
    +      Seq(true, false).foreach { multiline =>
    --- End diff --
    
    Sounds good to me.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message