spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #20360: [SPARK-23177][SQL][PySpark] Extract zero-paramete...
Date Tue, 23 Jan 2018 23:29:26 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20360#discussion_r163410447
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
---
    @@ -45,7 +45,8 @@ object ExtractPythonUDFFromAggregate extends Rule[LogicalPlan] {
     
       private def hasPythonUdfOverAggregate(expr: Expression, agg: Aggregate): Boolean =
{
         expr.find {
    -      e => PythonUDF.isScalarPythonUDF(e) && e.find(belongAggregate(_, agg)).isDefined
    --- End diff --
    
    Yes. Updated.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message