spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiangxb1987 <...@git.apache.org>
Subject [GitHub] spark pull request #20292: [SPARK-23129][CORE] Make deserializeStream of Dis...
Date Tue, 23 Jan 2018 05:49:16 GMT
Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20292#discussion_r163149829
  
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
    @@ -547,9 +555,9 @@ class ExternalAppendOnlyMap[K, V, C](
         private def cleanup() {
           batchIndex = batchOffsets.length  // Prevent reading any other batch
           val ds = deserializeStream
    --- End diff --
    
    The new val is not actually needed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message