spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From icexelloss <...@git.apache.org>
Subject [GitHub] spark pull request #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregati...
Date Tue, 16 Jan 2018 19:08:28 GMT
Github user icexelloss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19872#discussion_r161856360
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PythonUDF.scala
---
    @@ -15,12 +15,31 @@
      * limitations under the License.
      */
     
    -package org.apache.spark.sql.execution.python
    +package org.apache.spark.sql.catalyst.expressions
     
    -import org.apache.spark.api.python.PythonFunction
    -import org.apache.spark.sql.catalyst.expressions.{Expression, NonSQLExpression, Unevaluable,
UserDefinedExpression}
    +import org.apache.spark.api.python.{PythonEvalType, PythonFunction}
    +import org.apache.spark.sql.catalyst.util.toPrettySQL
     import org.apache.spark.sql.types.DataType
     
    +/**
    + * Helper functions for PythonUDF
    --- End diff --
    
    I changed to `[[PythonUDF]]`. I think Scala doc should use `[[]]`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message