spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #20232: [SPARK-23042][ML] Use OneHotEncoderModel to encod...
Date Fri, 12 Jan 2018 00:28:13 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20232#discussion_r161113685
  
    --- Diff: R/pkg/tests/fulltests/test_mllib_classification.R ---
    @@ -382,10 +382,10 @@ test_that("spark.mlp", {
       trainidxs <- base::sample(nrow(data), nrow(data) * 0.7)
       traindf <- as.DataFrame(data[trainidxs, ])
       testdf <- as.DataFrame(rbind(data[-trainidxs, ], c(0, "the other")))
    -  model <- spark.mlp(traindf, clicked ~ ., layers = c(1, 3))
    +  model <- spark.mlp(traindf, clicked ~ ., layers = c(1, 2))
    --- End diff --
    
    The old `layers` is wrong. The labels only have two values. cc @felixcheung 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message