spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smurakozi <...@git.apache.org>
Subject [GitHub] spark pull request #20203: [SPARK-22577] [core] executor page blacklist stat...
Date Thu, 11 Jan 2018 16:48:55 GMT
Github user smurakozi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20203#discussion_r161001141
  
    --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
    @@ -211,6 +211,11 @@ private[spark] class AppStatusListener(
         updateBlackListStatus(event.executorId, true)
       }
     
    +  override def onExecutorBlacklistedForStage(
    +    event: SparkListenerExecutorBlacklistedForStage): Unit = {
    +    updateBlackListStatusForStage(event.executorId, event.stageId, event.stageAttemptId)
    +  }
    +
    --- End diff --
    
    Consider covering this functionality (updating the status) in AppStatusListenerSuite.
We already have a check for blacklisting an executor, we should have the same for a stage.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message