spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #20217: [SPARK-23026] [PySpark] Add RegisterUDF to PySpar...
Date Thu, 11 Jan 2018 06:58:50 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20217#discussion_r160877051
  
    --- Diff: python/pyspark/sql/context.py ---
    @@ -578,6 +606,9 @@ def __init__(self, sqlContext):
         def register(self, name, f, returnType=StringType()):
             return self.sqlContext.registerFunction(name, f, returnType)
     
    +    def registerUDF(self, name, f):
    --- End diff --
    
    Yup +1 like https://github.com/apache/spark/pull/20217/files/f25669a4b6c2298359df1b9083037468652cd141#r160861434
but how about checking and doing this in batch? Seems we should fix the doctests too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message