spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ngone51 <...@git.apache.org>
Subject [GitHub] spark pull request #20199: [Spark-22967][TESTS]Fix VersionSuite's unit tests...
Date Wed, 10 Jan 2018 15:25:56 GMT
Github user Ngone51 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20199#discussion_r160709123
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala
---
    @@ -842,6 +842,7 @@ class VersionsSuite extends SparkFunSuite with Logging {
         }
     
         test(s"$version: SPARK-17920: Insert into/overwrite avro table") {
    +      assume(!(Utils.isWindows && version == "0.12"))
    --- End diff --
    
    @HyukjinKwon Ok, will comment.
    
    And I have find serval issues which exactly describe the same problem:
    - https://issues.apache.org/jira/browse/SPARK-12216
    - https://issues.apache.org/jira/browse/SPARK-8333
    - https://issues.apache.org/jira/browse/SPARK-18979
    
    It seems this is a common issue exists on Windows and haven't been resolved yet. And I
didn't find a accurate cause for the error from those issues. And now, I doubt this problem
maybe related to URLClassLoader. And, I have reproduce the same issue after I did a experiment
with URLClassLoader. Though, I'm not sure this is the real cause, yet. Working on this.
    
    We can merge this pr to master after I add comment. And open a new pr of that issue(if
fixed) or communicate under one of those issues. WDYT?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message