spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #20219: [SPARK-23025][SQL] Support Null type in scala ref...
Date Wed, 10 Jan 2018 14:15:30 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20219#discussion_r160687957
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala ---
    @@ -1441,6 +1441,13 @@ class DatasetSuite extends QueryTest with SharedSQLContext {
           assert(e.getCause.isInstanceOf[NullPointerException])
         }
       }
    +
    +  test("SPARK-23025: Add support for null type in scala reflection") {
    +    val data = Seq(("a", null))
    +    checkDataset(
    +      data.toDS(),
    +      data: _*)
    --- End diff --
    
    sure, since in this file in many places this syntax is used, should I change also other
usages accordingly?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message