spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ngone51 <...@git.apache.org>
Subject [GitHub] spark pull request #20199: [Spark-22967][Hive]Fix VersionSuite's unit tests ...
Date Tue, 09 Jan 2018 13:24:19 GMT
Github user Ngone51 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20199#discussion_r160404821
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala
---
    @@ -58,7 +58,7 @@ class VersionsSuite extends SparkFunSuite with Logging {
        */
       protected def withTempDir(f: File => Unit): Unit = {
         val dir = Utils.createTempDir().getCanonicalFile
    -    try f(dir) finally Utils.deleteRecursively(dir)
    +    f(dir)
    --- End diff --
    
    Actually, only one(2nd test mentioned above). Probably, `assume(!(Utils.isWindows &&
version == "0.12"))` would be ok. WDYT?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message