spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liyinan926 <...@git.apache.org>
Subject [GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...
Date Thu, 04 Jan 2018 19:46:27 GMT
Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20148#discussion_r159739212
  
    --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/BasicDriverConfigurationStep.scala
---
    @@ -119,7 +119,7 @@ private[spark] class BasicDriverConfigurationStep(
             .endEnv()
           .addNewEnv()
             .withName(ENV_DRIVER_ARGS)
    -        .withValue(appArgs.map(arg => "\"" + arg + "\"").mkString(" "))
    +        .withValue(appArgs.mkString(" "))
    --- End diff --
    
    A note on this change: it seems double quotes get literally added. With the double quotes
appended explicitly here, when running SparkPi with an argument 5, an NumberFormatException
will be thrown complaining that `""5""` is not parsable. So the explicit double quotes are
not really needed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message