spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #20024: [SPARK-22825][SQL] Fix incorrect results of Casti...
Date Thu, 04 Jan 2018 12:37:25 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20024#discussion_r159642789
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
    @@ -206,6 +206,23 @@ case class Cast(child: Expression, dataType: DataType, timeZoneId:
Option[String
         case DateType => buildCast[Int](_, d => UTF8String.fromString(DateTimeUtils.dateToString(d)))
         case TimestampType => buildCast[Long](_,
           t => UTF8String.fromString(DateTimeUtils.timestampToString(t, timeZone)))
    +    case ar: ArrayType =>
    --- End diff --
    
    nit: `case ArrayType(et, _)`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message