spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #20135: [SPARK-22937][SQL] SQL elt output binary for bina...
Date Thu, 04 Jan 2018 01:31:55 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20135#discussion_r159566662
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
    @@ -58,7 +58,7 @@ case class Concat(children: Seq[Expression]) extends Expression {
         } else {
           val childTypes = children.map(_.dataType)
           if (childTypes.exists(tpe => !Seq(StringType, BinaryType).contains(tpe))) {
    -        TypeCheckResult.TypeCheckFailure(
    +        return TypeCheckResult.TypeCheckFailure(
               s"input to function $prettyName should have StringType or BinaryType, but it's
" +
    --- End diff --
    
    Yes. Also create a test case


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message