Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: gatorsmile <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-19257-spark@git.apache.org>
In-Reply-To: <git-pr-19257-spark@git.apache.org>
Subject: [GitHub] spark pull request #19257: [SPARK-22042] [SQL] ReorderJoinPredicates can bre...
Content-Type: text/plain
Message-Id: <20171213072716.38A4EE38B8@git1-us-west.apache.org>
Date: Wed, 13 Dec 2017 07:27:16 +0000 (UTC)
archived-at: Wed, 13 Dec 2017 07:27:18 -0000

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19257#discussion_r156579889
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala ---
    @@ -248,13 +252,83 @@ case class EnsureRequirements(conf: SQLConf) extends Rule[SparkPlan] {
         operator.withNewChildren(children)
       }
     
    +  /**
    +   * When the physical operators are created for JOIN, the ordering of join keys is based on order
    +   * in which the join keys appear in the user query. That might not match with the output
    +   * partitioning of the join node's children (thus leading to extra sort / shuffle being
    +   * introduced). This rule will change the ordering of the join keys to match with the
    +   * partitioning of the join nodes' children.
    +   */
    +  def reorderJoinPredicates(plan: SparkPlan): SparkPlan = {
    --- End diff --
    
    private


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org