Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: vanzin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-19041-spark@git.apache.org>
In-Reply-To: <git-pr-19041-spark@git.apache.org>
Subject: [GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...
Content-Type: text/plain
Message-Id: <20171206230625.282CEF3319@git1-us-west.apache.org>
Date: Wed,  6 Dec 2017 23:06:25 +0000 (UTC)
archived-at: Wed, 06 Dec 2017 23:06:27 -0000

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19041#discussion_r155387718
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/RecoverCachedDataSuite.scala ---
    @@ -0,0 +1,127 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.scheduler
    +
    +import scala.util.Try
    +
    +import org.scalatest.{BeforeAndAfterEach, Matchers}
    +
    +import org.apache.spark.{SparkConf, SparkContext, SparkFunSuite, TestUtils}
    +import org.apache.spark.network.TransportContext
    +import org.apache.spark.network.netty.SparkTransportConf
    +import org.apache.spark.network.server.TransportServer
    +import org.apache.spark.network.shuffle.ExternalShuffleBlockHandler
    +import org.apache.spark.rdd.RDD
    +import org.apache.spark.storage._
    +
    +class RecoverCachedDataSuite extends SparkFunSuite with Matchers with BeforeAndAfterEach {
    +
    +  var shuffleService: TransportServer = _
    +  var conf: SparkConf = _
    +  var sc: SparkContext = _
    +
    +  private def makeBaseConf() = new SparkConf()
    +    .setAppName("test")
    +    .setMaster("local-cluster[4, 1, 512]")
    +    .set("spark.executor.memory", "512m")
    +    .set("spark.shuffle.service.enabled", "true")
    +    .set("spark.dynamicAllocation.enabled", "true")
    --- End diff --
    
    Use config constants where possible.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org