spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #19964: [SPARK-22772][SQL] Use splitExpressionsWithCurren...
Date Wed, 13 Dec 2017 10:57:49 GMT
GitHub user viirya opened a pull request:

    https://github.com/apache/spark/pull/19964

    [SPARK-22772][SQL] Use splitExpressionsWithCurrentInputs to split codes in elt

    ## What changes were proposed in this pull request?
    
    In SPARK-22550 which fixes 64KB JVM bytecode limit problem with elt, `buildCodeBlocks`
is used to split codes. However, we should use `splitExpressionsWithCurrentInputs` because
it considers both normal and wholestage codgen (it is not supported yet, so it simply doesn't
split the codes).
    
    ## How was this patch tested?
    
    Existing tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/viirya/spark-1 SPARK-22772

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19964
    
----
commit c40488ef33bb81caa7a2d99fc4d1b4de6c462ee3
Author: Liang-Chi Hsieh <viirya@gmail.com>
Date:   2017-12-13T10:52:55Z

    Use splitExpressionsWithCurrentInputs to split codes in elt.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message