spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ueshin <...@git.apache.org>
Subject [GitHub] spark pull request #19970: [SPARK-22775][SQL] move dictionary related APIs f...
Date Thu, 14 Dec 2017 03:05:11 GMT
Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19970#discussion_r156843445
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
    @@ -145,39 +135,39 @@
       public abstract double[] getDoubles(int rowId, int count);
     
       /**
    -   * Returns the length of the array at rowid.
    +   * Returns the length of the array for rowId.
        */
       public abstract int getArrayLength(int rowId);
     
       /**
    -   * Returns the offset of the array at rowid.
    +   * Returns the offset of the array for rowId.
        */
       public abstract int getArrayOffset(int rowId);
     
       /**
    -   * Returns a utility object to get structs.
    +   * Returns the struct for rowId.
        */
       public final ColumnarRow getStruct(int rowId) {
         return new ColumnarRow(this, rowId);
       }
     
       /**
    -   * Returns a utility object to get structs.
    -   * provided to keep API compatibility with InternalRow for code generation
    +   * A special version of {@link #getShort(int)}, which is only used as an adapter for
Spark codegen
    --- End diff --
    
    `getStruct(int)` instead of `getShort(int)`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message