spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #19864: [SPARK-22673][SQL] InMemoryRelation should utiliz...
Date Wed, 13 Dec 2017 02:58:56 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19864#discussion_r156554180
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
    @@ -80,6 +80,14 @@ class CacheManager extends Logging {
         cachedData.isEmpty
       }
     
    +  private def extractStatsOfPlanForCache(plan: LogicalPlan): Option[Statistics] = {
    +    if (plan.stats.rowCount.isDefined) {
    --- End diff --
    
    +1


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message